chore: resolve remaining switch-exhaustiveness-check warnings#7113
Merged
isaacroldan merged 1 commit intomainfrom Mar 27, 2026
Merged
Conversation
Contributor
Author
This stack of pull requests is managed by Graphite. Learn more about stacking. |
isaacroldan
force-pushed
the
03-26-chore_resolve_remaining_switch-exhaustiveness-check_warnings
branch
from
219a35f to
5617f2f
Compare
isaacroldan
force-pushed
the
03-26-chore_fix_87_eslint_warnings_across_the_codebase
branch
2 times, most recently
from
351844e to
d167d8f
Compare
isaacroldan
force-pushed
the
03-26-chore_resolve_remaining_switch-exhaustiveness-check_warnings
branch
2 times, most recently
from
b348343 to
a45bace
Compare
isaacroldan
force-pushed
the
03-26-chore_fix_87_eslint_warnings_across_the_codebase
branch
2 times, most recently
from
731c405 to
7d8f828
Compare
isaacroldan
force-pushed
the
03-26-chore_resolve_remaining_switch-exhaustiveness-check_warnings
branch
from
a45bace to
d9a2ee6
Compare
Contributor
Coverage report
Test suite run success3993 tests passing in 1527 suites. Report generated by 🧪jest coverage report action from 5d67093 |
isaacroldan
force-pushed
the
03-26-chore_fix_87_eslint_warnings_across_the_codebase
branch
from
7d8f828 to
b23df55
Compare
isaacroldan
force-pushed
the
03-26-chore_resolve_remaining_switch-exhaustiveness-check_warnings
branch
from
d9a2ee6 to
62a7259
Compare
Contributor
|
We detected some changes at Caution DO NOT create changesets for features which you do not wish to be included in the public changelog of the next CLI release. |
isaacroldan
force-pushed
the
03-26-chore_fix_87_eslint_warnings_across_the_codebase
branch
from
b23df55 to
ccb06f4
Compare
isaacroldan
force-pushed
the
03-26-chore_resolve_remaining_switch-exhaustiveness-check_warnings
branch
from
62a7259 to
4535e02
Compare
Fix all 20 remaining eslint warnings (switch-exhaustiveness-check): - fqdn.ts: file-level suppress — all switches branch on 'local' vs default (production). Tests mock serviceEnvironment() returning undefined, so explicit enum cases break tests. - scopes.ts: add explicit 'admin'|'storefront-renderer' cases that throw - output.ts: add missing 'silent' case to logLevelValue - tree-kill.ts: suppress — default handles all Unix-like platforms - mkcert.ts: suppress — default throws for unsupported platforms - Logs.tsx: replace default with explicit BackgroundExecutionReason.Unknown - execute-bulk-operation.ts: replace default with explicit error status cases - format-bulk-operation-status.ts: replace default with explicit status cases - extension.ts: replace default with explicit undefined|liquid|config-only - declarative-definitions.ts: replace defaults with explicit GraphQL enum cases - extension-config-builder.ts: replace default with explicit undefined case, use ?? instead of || for context fallback chain Combined with the parent PR, this brings the codebase from 107 warnings to 0. Co-authored-by: Claude Code <claude-code@anthropic.com>
isaacroldan
force-pushed
the
03-26-chore_resolve_remaining_switch-exhaustiveness-check_warnings
branch
from
4535e02 to
5d67093
Compare
| case BackgroundExecutionReason.CacheAboutToExpire: | ||
| return 'Cache is about to expire' | ||
| default: | ||
| case BackgroundExecutionReason.Unknown: |
Contributor
There was a problem hiding this comment.
shoul'd we still have a default case here just in case? same in the others, why not a default?
Contributor
Author
There was a problem hiding this comment.
not having a default forces you to implement a caseif you add a new option to the Enum. The default would silently catch it.
Base automatically changed from
03-26-chore_fix_87_eslint_warnings_across_the_codebase
to
main
March 27, 2026 12:45
gonzaloriestra
approved these changes
Mar 27, 2026
isaacroldan
deleted the
03-26-chore_resolve_remaining_switch-exhaustiveness-check_warnings
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
WHY are these changes introduced?
Fixes #0000
WHAT is this pull request doing?
How to test your changes?
Post-release steps
Measuring impact
How do we know this change was effective? Please choose one:
Checklist